Re: [PATCH 2/3] string: provide strscpy() and strscpy_truncate()

From: Geert Uytterhoeven
Date: Wed May 06 2015 - 12:46:03 EST


On Wed, May 6, 2015 at 5:59 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> We actually do have a __must_check tag so it's easy enough to force
> people to check. A different option is we could make it trigger a

People tend to ignore compiler warnings...

> WARN_ONCE().
>
> #define strXcpy(dest, src, len) (({ \
> ssize_t __ret = strscpy_truncate(dest, src, len); \
> WARN_ONCE(__ret < 0, "strXcpy trancates\n"); \
> __ret; }))

Which will probably trigger only in extreme cases in the wild, not during
development.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/