Re: [PATCH 05/10] uprobes: Change handle_trampoline() to find the next chain beforehand

From: Srikar Dronamraju
Date: Thu May 07 2015 - 06:33:31 EST


* Oleg Nesterov <oleg@xxxxxxxxxx> [2015-05-04 14:49:06]:

> No functional changes, preparation.
>
> Add the new helper, find_next_ret_chain(), which finds the first !chained
> entry and returns its ->next. Yes, it is suboptimal. We probably want to
> turn ->chained into ->start_of_this_chain pointer and avoid another loop.
> But this needs the boring changes in dup_utask(), so lets do this later.
>
> Change the main loop in handle_trampoline() to unwind the stack until ri
> is equal to the pointer returned by this new helper.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Looks good to me.

Acked-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>
--
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/