Re: [PATCH 07/10] uprobes/x86: Introduce arch_uretprobe_is_alive()

From: Srikar Dronamraju
Date: Thu May 07 2015 - 06:36:26 EST


* Oleg Nesterov <oleg@xxxxxxxxxx> [2015-05-04 14:49:14]:

> Add the x86-specific arch_uretprobe_is_alive() helper and define its
> "weak" version for other architectures.
>
> It returns true if the stack frame mangled by prepare_uretprobe() is
> still on stack. So if it returns false, we know that the probed func
> has already returned.
>
> TODO: this assumes that the probed app can't use multiple stacks (say
> sigaltstack). We will try to improve this logic later.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Looks good to me.

Acked-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>
> ---
--
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/