Re: [ÍPATCHv4 01/12] usb: add bus type for USB ULPI

From: Heikki Krogerus
Date: Fri May 08 2015 - 05:58:38 EST


On Thu, May 07, 2015 at 10:46:04PM +0200, Greg Kroah-Hartman wrote:
> On Thu, May 07, 2015 at 09:19:21AM +0300, Heikki Krogerus wrote:
> > +config USB_ULPI_BUS
> > + bool "USB ULPI PHY interface support"
>
> Can't we make this a module?

There is actually nothing preventing it.

I removed the possibility of building this as a module at one point
because... I guess just because a voice inside my head told me to do
so. Thanks for catching this one.

> > + depends on USB_SUPPORT
> > + help
> > + Say yes if you have ULPI PHY attached to your USB controller.
>
> You need to put more information here as to what "ULPI" means, and how
> would anyone know if they have this type of thing attached to their USB
> controller.
>
> You need to help users / distros out in letting them know if they should
> enable this or not. As it is, I have no idea if I should even enable
> this on my systems...

OK.


Thanks,

--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/