Re: [PATCH v2] serial: imx: Revert "initialized DMA w/o HW flow enabled"

From: Fabio Estevam
Date: Fri May 08 2015 - 07:30:54 EST


On Fri, May 8, 2015 at 4:13 AM, Sebastian Andrzej Siewior
<sebastian@xxxxxxxxxxxxx> wrote:

> +
> + /*
> + * Can we enable the DMA support? Be aware that
> + * at least IMX6 needs to load external SDMA firmware in
> + * order work properly. The in-ROM firmware is not
> + * wokring properly.
> + */

On my tests:

Prior to this patch: with the internal ROM SDMA firmware I got UART
issues when communicating through a Bluetooth module. With external
SDMA firmware (version 3.1) it worked fine.

With your patch applied: Bluetooth worked fine even with no external
SDMA firmware, which does not match the comments you added.

Can't you just remove these comments?

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/