Re: [PATCH v2 2/2] arm64: dts: qcom: Add msm8916 CoreSight components

[Ivan T. Ivanov]

On Fri, 2015-05-08 at 08:13 -0600, Mathieu Poirier wrote:
> On 8 May 2015 at 07:47, Ivan T. Ivanov ivanov@xxxxxxxxxx> wrote:
> > On Fri, 2015-05-08 at 07:38 -0600, Mathieu Poirier wrote:
> > > On 7 May 2015 at 09:36, Ivan T. Ivanov ivanov@xxxxxxxxxx> wrote:
> > > > Add initial set of CoreSight components found on Qualcomm's 8x16 chipset.
> > > > 
> > > > 
> > > > +ÂÂÂÂÂÂÂreplicator@824000 {
> > > > +               compatible = "qcom,coresight-replicator", "arm,primecell";
> > > 
> > > Shouldn't it be "qcom,coresight-replicator1x" ?
> > > 
> > 
> > 
> > 
> > True, I still wonder, why we have to have this compatible string?
> > Drivers are probed by amba_id and "arm,primecell", after all.
> > 
> 
> Drivers have their own compatible strings for historical reasons,
> something I've been meaning to fix for a long time now...
> 

Yep, I see that they have been platform drivers in the past, but now 
they are not, except coresight-replicator driver. IMHO, having
additional compatible string could lead just to confusion. 

Regards,
Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/