Re: [PATCH v4 3/3] usb: xhci: remove stop device and ring doorbell in hub control and bus suspend

[Lu, Baolu]

On 05/08/2015 07:01 PM, Greg Kroah-Hartman wrote:
> On Fri, May 08, 2015 at 06:26:28PM +0800, Lu Baolu wrote:
> > There is no need to call xhci_stop_device() and xhci_ring_device() in
> > hub control and bus suspend functions since all device suspend and
> > resume have been notified through device_suspend/device_resume interfaces.
> Does this mean that after patch 2, things are broken and require this
> patch to prevent problems?

No. things work well without patch 3. "stop device" and "ring doorbell"
operations in hub control and bus suspend is harmless, but duplicated
and unnecessary, so I remove them.

> I don't want to have any patch to make the system unstable.
>
> thanks,
>
> greg k-h

Thank you,
Baolu

> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/