Re: [PATCH 3/6] clk: sunxi: Add A33 clock for compilation

From: Vishnu Patekar
Date: Mon May 11 2015 - 04:53:59 EST


Hi,

On Sun, May 10, 2015 at 3:47 PM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> Hi,
>
> On Sun, May 10, 2015 at 12:16:20PM +0530, Vishnu Patekar wrote:
>> A33 clock control unit is similar to A23.
>>
>> A33 specific clocks are not yet implemented, added CLK_OF_DECLARE
>> to get it compiled for A33.
>
> That commit log doesn't make any sense.
>
> What you're doing isn't about whether or not that will be compiled,
> but whether you're registering the clocks and which clocks you
> protect.
Actually, It's just registering the a33 clocks and reusing a23 code.
nothing to do with compile. I'll correct it in next patch version.
>
>> Signed-off-by: VishnuPatekar <vishnupatekar0510@xxxxxxxxx>
>
> Isn't it supposed to have a space in the middle of your name, just
> like you have in your mail address?
Yes, There should be space.
>
> Thanks,
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/