Re: [PATCH v7 1/3] dt-bindings: Add I2C bindings for mt65xx/mt81xx.

From: wsa
Date: Tue May 12 2015 - 08:37:52 EST


On Wed, May 06, 2015 at 04:37:05PM +0800, Eddie Huang wrote:
> From: Xudong Chen <xudong.chen@xxxxxxxxxxxx>
>
> Add devicetree bindings for Mediatek Soc I2C driver.
>
> Signed-off-by: Xudong Chen <xudong.chen@xxxxxxxxxxxx>
> Signed-off-by: Eddie Huang <eddie.huang@xxxxxxxxxxxx>

Sascha, Uwe: Can you ack these patches if you are fine with them?
Would be nice since you did quite some review and were involved in the
"have-pmic" binding discussion.

Thanks,

Wolfram

> ---
> .../devicetree/bindings/i2c/i2c-mt6577.txt | 41 ++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> new file mode 100644
> index 0000000..0ce6fa3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> @@ -0,0 +1,41 @@
> +* Mediatek's I2C controller
> +
> +The Mediatek's I2C controller is used to interface with I2C devices.
> +
> +Required properties:
> + - compatible: value should be either of the following.
> + (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
> + (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
> + (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
> + (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
> + (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
> + - reg: physical base address of the controller and dma base, length of memory
> + mapped region.
> + - interrupts: interrupt number to the cpu.
> + - clock-div: the fixed value for frequency divider of clock source in i2c
> + module. Each IC may be different.
> + - clocks: clock name from clock manager
> + - clock-names: Must include "main" and "dma", if enable have-pmic need include
> + "pmic" extra.
> +
> +Optional properties:
> + - clock-frequency: Frequency in Hz of the bus when transfer, the default value
> + is 100000.
> + - mediatek,have-pmic: platform can control i2c form special pmic side.
> + Only mt6589 and mt8135 support this feature.
> + - mediatek,use-push-pull: IO config use push-pull mode.
> +
> +Example:
> +
> + i2c0: i2c@1100d000 {
> + compatible = "mediatek,mt6577-i2c";
> + reg = <0x1100d000 0x70>,
> + <0x11000300 0x80>;
> + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>;
> + clock-frequency = <400000>;
> + mediatek,have-pmic;
> + clock-div = <16>;
> + clocks = <&i2c0_ck>, <&ap_dma_ck>;
> + clock-names = "main", "dma";
> + };
> +
> --
> 1.8.1.1.dirty
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/