Re: [PATCH 2/2 v2] lib/vsprintf.c: Further simplify uuid_string()

From: George Spelvin
Date: Tue May 12 2015 - 09:57:41 EST


> Acked-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
>
> You may want/need to include Andrew Morton in the cc-list to get these
> picked up.

Thank you; I sent it to you because I'm not sure who's really in charge
of this.

>> + /* Insert the fixed punctuation */
>> + uuid[23] = uuid[18] = uuid[13] = uuid[8] = '-';
>> + uuid[36] = 0;

> I think '\0' is more common.

It's that way beause of it was replacing

>> - *p = 0;

But yes, I prefer the char constant, too. And it would be consistent with
the rest of the file.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/