Re: [PATCH] ARM: berlin: add CPU hotplug support

From: Russell King - ARM Linux
Date: Tue May 12 2015 - 19:23:41 EST


On Tue, May 12, 2015 at 04:16:26PM +0200, Antoine Tenart wrote:
> Adds CPU hotplug support for Berlin SoCs (currently BG2 and BG2Q). The
> CPUs are put in WFI after disabling the coherency.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@xxxxxxxxxxxxxxxxxx>
> ---
> arch/arm/mach-berlin/platsmp.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/mach-berlin/platsmp.c b/arch/arm/mach-berlin/platsmp.c
> index 702e7982015a..d9c62057be76 100644
> --- a/arch/arm/mach-berlin/platsmp.c
> +++ b/arch/arm/mach-berlin/platsmp.c
> @@ -14,6 +14,7 @@
> #include <linux/of_address.h>
>
> #include <asm/cacheflush.h>
> +#include <asm/cp15.h>

I don't see anything being added by this patch which would need this
include.

> #include <asm/smp_plat.h>
> #include <asm/smp_scu.h>
>
> @@ -92,8 +93,20 @@ unmap_scu:
> iounmap(scu_base);
> }
>
> +#ifdef CONFIG_HOTPLUG_CPU
> +static void berlin_cpu_die(unsigned int cpu)
> +{
> + v7_exit_coherency_flush(louis);
> + while (1)
> + cpu_do_idle();
> +}
> +#endif
> +
> static struct smp_operations berlin_smp_ops __initdata = {
> .smp_prepare_cpus = berlin_smp_prepare_cpus,
> .smp_boot_secondary = berlin_boot_secondary,
> +#ifdef CONFIG_HOTPLUG_CPU
> + .cpu_die = berlin_cpu_die,
> +#endif
> };
> CPU_METHOD_OF_DECLARE(berlin_smp, "marvell,berlin-smp", &berlin_smp_ops);
> --
> 2.4.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/