Re: [PATCH tip/core/rcu 4/4] netfilter: Fix list_entry_rcu usage

From: Steven Rostedt
Date: Tue May 12 2015 - 22:42:49 EST


On Tue, 12 May 2015 15:46:27 -0700
"Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx> wrote:

> From: Patrick Marlier <patrick.marlier@xxxxxxxxx>
>
> Signed-off-by: Patrick Marlier <patrick.marlier@xxxxxxxxx>
> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> ---
> net/netfilter/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/core.c b/net/netfilter/core.c
> index e6163017c42d..ad70195929a4 100644
> --- a/net/netfilter/core.c
> +++ b/net/netfilter/core.c
> @@ -166,7 +166,7 @@ int nf_hook_slow(struct sk_buff *skb, struct nf_hook_state *state)
> /* We may already have this, but read-locks nest anyway */
> rcu_read_lock();
>
> - elem = list_entry_rcu(&nf_hooks[state->pf][state->hook],
> + elem = list_entry_rcu(nf_hooks[state->pf][state->hook].next,
> struct nf_hook_ops, list);

Looks to be setting to the next element, not the current one.

-- Steve



> next_hook:
> verdict = nf_iterate(&nf_hooks[state->pf][state->hook], skb, state,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/