Re: [PATCH V4 2/3] devicetree: Add bindings for DA9063 OnKey

From: Lee Jones
Date: Wed May 13 2015 - 06:34:36 EST


On Tue, 12 May 2015, S Twiss wrote:

> From: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
>
> Add device tree bindings for the DA9063 OnKey driver
>
>
> Signed-off-by: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
>
> ---
> Version History
>
> Changes in V4
> - No change
>
> Changes in V3
> - No change
>
> Changes in V2
> - Remove the circular dependency comment linking patches in the main e-mail
> - Search and replace 'keyword' with 'property' in onkey sub-node description
> - Reformat onkey sub-node content to move the description for key-power into
> a new optional properties sub-section so it has a more promiment position
>
> This patch applies against linux-next and v4.1-rc3
>
>
> Documentation/devicetree/bindings/mfd/da9063.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)

I'll wait to see what Dmitry has to say before applying, but for my
own reference:

Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

> diff --git a/Documentation/devicetree/bindings/mfd/da9063.txt b/Documentation/devicetree/bindings/mfd/da9063.txt
> index 42c6fa6..05b21bc 100644
> --- a/Documentation/devicetree/bindings/mfd/da9063.txt
> +++ b/Documentation/devicetree/bindings/mfd/da9063.txt
> @@ -5,6 +5,7 @@ DA9093 consists of a large and varied group of sub-devices (I2C Only):
> Device Supply Names Description
> ------ ------------ -----------
> da9063-regulator : : LDOs & BUCKs
> +da9063-onkey : : On Key
> da9063-rtc : : Real-Time Clock
> da9063-watchdog : : Watchdog
>
> @@ -51,6 +52,18 @@ Sub-nodes:
> the DA9063. There are currently no entries in this binding, however
> compatible = "dlg,da9063-rtc" should be added if a node is created.
>
> +- onkey : This node defines the OnKey settings for controlling the key
> + functionality of the device. The node should contain the compatible property
> + with the value "dlg,da9063-onkey".
> +
> + Optional onkey properties:
> +
> + - dlg,disable-key-power : Disable power-down using a long key-press. If this
> + entry exists the OnKey driver will remove support for the KEY_POWER key
> + press. If this entry does not exist then by default the key-press
> + triggered power down is enabled and the OnKey will support both KEY_POWER
> + and KEY_SLEEP.
> +
> - watchdog : This node defines settings for the Watchdog timer associated
> with the DA9063. There are currently no entries in this binding, however
> compatible = "dlg,da9063-watchdog" should be added if a node is created.
> @@ -73,6 +86,11 @@ Example:
> compatible = "dlg,da9063-watchdog";
> };
>
> + onkey {
> + compatible = "dlg,da9063-onkey";
> + dlg,disable-key-power;
> + };
> +
> regulators {
> DA9063_BCORE1: bcore1 {
> regulator-name = "BCORE1";

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/