Re: [PATCH v6 1/2] PCI/MSI: Don't disable MSI/MSI-X at shutdown

[Michael S. Tsirkin]

On Wed, May 13, 2015 at 08:41:55AM +0200, Michael S. Tsirkin wrote:
> > This also sounds like a case for implementing a shutdown callback and
> > disabling things properly.  A properly shutdown driver should have
> > already disabled MSI's.  A driver is responsible for enabling MSIs so it
> > should be responsible for disabling it.  The core disabling MSIs is
> > mostly to catch the handful of lazy drivers that forget.
> 
> 
> Okay! And I am saying that if the driver did forget,
> we are better off not disabling it - leave it enabled
> until kexec starts and disables it.
> 
> 
> > The bottom line is that there are a few things that are standard
> > behavior that we can do in the generic code, but at the end of the day
> > it is the responsibility of the driver to shut things down and whatever
> > driver you are dealing with clearly has a bunch of bugs and you aren't
> > fixing it. 
> 
> So please let us get on with fixing it in driver and stop
> playing with device in core.

Eric, does this argument make sense?  Drivers should do the right thing
in their shutdown callback, let's not try to work around their bugs in
core.

-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/