[PATCH] staging: rts5208: remove always true comparison

From: Sudip Mukherjee
Date: Thu May 14 2015 - 10:26:14 EST


the if comparison is always true as anything bitwise and-ing with 0x1E
can never be equal to 0x03.

Fixes bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=69881

Reported-by: David Binderman <dcb314@xxxxxxxxxxx>
Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
---
drivers/staging/rts5208/sd.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index a8d657b..2e3f1f4 100644
--- a/drivers/staging/rts5208/sd.c
+++ b/drivers/staging/rts5208/sd.c
@@ -4170,10 +4170,8 @@ RTY_SEND_CMD:
}

} else if (rsp_type == SD_RSP_TYPE_R0) {
- if ((ptr[3] & 0x1E) != 0x03) {
- rtsx_trace(chip);
- return STATUS_FAIL;
- }
+ rtsx_trace(chip);
+ return STATUS_FAIL;
}
}
}
--
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/