Re: [PATCH 05/14] ceph: Use kvfree() in ceph_put_page_vector()

From: Yan, Zheng
Date: Mon May 18 2015 - 03:05:52 EST



> On May 16, 2015, at 02:35, Pekka Enberg <penberg@xxxxxxxxxx> wrote:
>
> Use kvfree instead of open-coding it.
>
> Cc: "Yan, Zheng" <zyan@xxxxxxxxxx>
> Cc: Sage Weil <sage@xxxxxxxxxx>
> Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxx>
> ---
> net/ceph/pagevec.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c
> index 096d914..d4f5f22 100644
> --- a/net/ceph/pagevec.c
> +++ b/net/ceph/pagevec.c
> @@ -51,10 +51,7 @@ void ceph_put_page_vector(struct page **pages, int num_pages, bool dirty)
> set_page_dirty_lock(pages[i]);
> put_page(pages[i]);
> }
> - if (is_vmalloc_addr(pages))
> - vfree(pages);
> - else
> - kfree(pages);
> + kvfree(pages);
> }
> EXPORT_SYMBOL(ceph_put_page_vector);

Thanks. but Ilya Dryomov has already submitted a similar patch.

>
> --
> 2.1.0
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/