Re: [RFC][PATCH 4/4] sched, numa: Ignore pinned tasks

[Srikar Dronamraju]

>  
>  static void account_numa_dequeue(struct rq *rq, struct task_struct *p)
>  {
> +	if (p->nr_cpus_allowed == 1) {
> +		rq->nr_pinned_running--;
> +		WARN_ON_ONCE(p->numa_preferred_nid != -1);
> +	}
>  	rq->nr_numa_running -= (p->numa_preferred_nid != -1);
>  	rq->nr_preferred_running -= (p->numa_preferred_nid == task_node(p));
>  }


Shouldnt we reset p->numa_preferred_nid when we are setting the allowed
cpus in set_cpus_allowed_common()? 

Otherwise if an process is set a preferred node based on its numa faults
but then is pinned to a different cpu, then we can see this warning.:w!


-- 
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/