On Thu, May 14, 2015 at 10:26:41PM +0200, Geert Uytterhoeven wrote:
On Thu, May 14, 2015 at 7:46 PM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote:
On 05/14/2015 11:32 AM, Brian Norris wrote:
In commit 8ff16cf77ce3 ("Documentation: devicetree: m25p80: add
"nor-jedec"
binding"), we added a generic "nor-jedec" binding to catch all
mostly-compatible SPI NOR flash which can be detected via the READ ID
opcode (0x9F). This was discussed and reviewed at the time, however
objections have come up since then as part of this discussion:
http://lkml.kernel.org/g/20150511224646.GJ32500@ld-irv-0074
It seems the parties involved agree that "jedec,spi-nor" does a better
job of capturing the fact that this is SPI-specific, not just any NOR
flash.
This binding was only merged for v4.1-rc1, so it's still OK to change
the naming.
At the same time, let's move the documentation to a better name.
Next up: prune the m25p_ids[] table to the minimal necessary listing, so
we can stop referring to code (drivers/mtd/devices/m25p80.c) from the
documentation.
There's no need to change the code to update the documentation. Simply paste
the list of valid device IDs into the documentation. The binding
documentation needs to be completely standalone anyway. Binding
documentation should never refer to Linux driver code as part of their
definition.
Of course they shouldn't refer to the driver. That's the main point of
my comment. But just because the ID made its way into the driver doesn't
mean it's always a useful or necessary DT binding. More below.