Re: [PATCH v5 09/21] clk: tegra: pll: Add logic for handling SDM data

From: Benson Leung
Date: Mon May 18 2015 - 18:35:28 EST


On Tue, May 12, 2015 at 10:23 AM, Rhyland Klein <rklein@xxxxxxxxxx> wrote:
> This adds logic for taking SDM_DIN (Sigma Delta Modulator) setting into
> the equation to calculate the effective N value for PLL which supports
> fractional divider.
>
> The effective N = NDIV + 1/2 + SDM_DIN/2^13, where NDIV is the integer
> feedback divider.
>
> Signed-off-by: Rhyland Klein <rklein@xxxxxxxxxx>

Reviewed-by: Benson Leung <bleung@xxxxxxxxxxxx>

Thanks for making the suggested changes.
> ---
> v5:
> - made use of sdm_en_mask when possible to clean up logic
> - added kerneldoc info for new struct params
> - Added info about SDM near sdm_set_data
> - rewrote check in sdm_set_data to make it clearer




--
Benson Leung
Software Engineer, Chrom* OS
bleung@xxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/