RE: [rtc-linux] RE: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

[Opensource [Steve Twiss]]

On 18 May 2015 18:39 Alexandre Belloni wrote:

> Sure, what I understand is that the base functionality is the same and
> even the registers are compatible. Are you sure the new features can't
> be added to the da9063 and called conditionally? Plenty of drivers are
> doing that.

Hi Alexandre/Guenter,

I didn't say it couldn't be added to DA9063. Of course it's all possible, but I think
it would become unmaintainable in future without separate drivers. There is some
extra freeze functionality and a watchdog warn interrupt: both do not exist in the
DA9063.

What I did say **one month ago** was the DA9062 watchdog driver does have some
similarities with the DA9063 watchdog (https://lkml.org/lkml/2015/5/6/505).

But I would prefer two drivers for watchdog in this case. When compared to the RTC and
OnKey the watchdog is very different on the hardware side. Despite the appearance of
some similarity, the watchdog is not a functional clone like the RTC and OnKey components.

I would not like a combined watchdog driver because I think that the extra functions
that the DA9062 contains would bloat out the DA9063 watchdog, and would make it difficult
to test and to maintain for the future..

Regards,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/