Re: [PATCH v1 03/12] crypto: qat - address recursive dependency when fw signing is enabled

[Luis R. Rodriguez]

On Tue, May 19, 2015 at 10:02:15AM +0200, Paul Bolle wrote:
> On Tue, 2015-05-19 at 02:09 +0200, Luis R. Rodriguez wrote:
> > On Mon, May 18, 2015 at 10:45:30PM +0200, Paul Bolle wrote:
> > > [...] so, probably, almost
> > > all .config files have FW_LOADER set. So I think, except for some corner
> > > cases, either converting all "select FW_LOADER" to "depends on
> > > FW_LOADER" or simply dropping  "select FW_LOADER" all together, should
> > > be fine.
> > 
> > Well, that makes sense. I just dropped all "select FW_LOADER" entries
> > on next-20150518, then I enabled everything with 'make allyesconfig'
> > and then went into menuconfig to disable FW_LOADER. The build worked.
> > 
> > Going to try a few more build matrix combinations and send patches to
> > do away with this.
> > 
> > > Those corner cases should then be handled on a case by case basis. 
> 
> Having slept on this, it occurred to me a randconfig could hit those
> corner cases. (Make that will hit them, actually.) Of course, one might
> argue that randconfig and EXPERT's advice, "Only use this if you really
> know what you are doing.", are at odds. Which opens another can of
> worms: how much do we care about .config files in which randconfig
> visited the kernels darker corners? Just enough, I'm afraid.
> 
> So it seems I've wasted your time by suggesting to drop those selects.

IMHO not at all.

> And now I wonder what trouble using "depends on" will generate here...

Instead of depends on we should just drop it and and issues arise we
should fix them provided an allyesconfig and allmodconfig work when
FW_LOADER is disabled. That was the approach I wanted to take at
least. To make this easier to phase we can break it down by subsystem.

Thoughts?

 Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/