Re: [PATCH v3 1/2] Staging: comedi: fix line longer than 80 chars in cb_pcidas64.c

[Sudip Mukherjee]

On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote:
> This patch fixes coding style errors reported by checkpatch.pl for
> cb_pcidas64.c, about too long source code lines.
> 
> Signed-off-by: Amaury Denoyelle <amaury.denoyelle@xxxxxxxxx>
> ---
>  drivers/staging/comedi/drivers/cb_pcidas64.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index a94c33c..f1bba2b 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
<snip>
> @@ -1381,7 +1382,9 @@ static int set_ai_fifo_segment_length(struct comedi_device *dev,
>  	return devpriv->ai_fifo_segment_length;
>  }
>  
> -/* adjusts the size of hardware fifo (which determines block size for dma xfers) */
> +/*
> + * adjusts the size of hardware fifo (which determines block size for dma xfers)
> + */
I did not understand this one. You are not breaking the comment into
two lines, then why multiline style?

>  	const struct pcidas64_board *thisboard = dev->board_ptr;
> @@ -1588,7 +1591,9 @@ static inline void warn_external_queue(struct comedi_device *dev)
>  		"Use internal AI channel queue (channels must be consecutive and use same range/aref)\n");
>  }
>  
> -/* Their i2c requires a huge delay on setting clock or data high for some reason */
> +/*
> + * their i2c requires a huge delay on setting clock or data high for some reason
> + */
same here.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/