[EDT] [PATCH] devpts/inode.c : Fix Possible dentry NULL dereference

From: Maninder Singh
Date: Thu May 21 2015 - 06:29:01 EST



EP-F6AA0618C49C4AEDA73BFF1B39950BAB

Hi,

Subject: [PATCH 1/1] devpts/inode.c : Fix Possible dentry NULL dereference

Issue reported by static tool Analyzer (Prevent).
d_find_alias can return NULL to deentry, Thus we need NULL check
before calling d_delete(dentry)

Signed-off-by: Maninder Singh <maninder1.s@xxxxxxxxxxx>
Reviewed-by: Vaneet Narang <v.narang@xxxxxxxxxxx>
---
fs/devpts/inode.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
index add5663..0350ac2 100644
--- a/fs/devpts/inode.c
+++ b/fs/devpts/inode.c
@@ -663,7 +663,8 @@ void devpts_pty_kill(struct inode *inode)
dentry = d_find_alias(inode);

drop_nlink(inode);
- d_delete(dentry);
+ if (dentry)
+ d_delete(dentry);
dput(dentry); /* d_alloc_name() in devpts_pty_new() */
dput(dentry); /* d_find_alias above */

--
1.7.1

Thanks ,
Maninder Singh