Re: [EDT] [PATCH] devpts/inode.c : Fix Possible dentry NULL dereference

From: Al Viro
Date: Thu May 21 2015 - 07:12:50 EST


On Thu, May 21, 2015 at 10:28:52AM +0000, Maninder Singh wrote:

> Subject: [PATCH 1/1] devpts/inode.c : Fix Possible dentry NULL dereference
>
> Issue reported by static tool Analyzer (Prevent).
> d_find_alias can return NULL to deentry, Thus we need NULL check
> before calling d_delete(dentry)

No, we do not. That inode must have come from devpts_pty_new() and it
wouldn't have made it out of there without having a dentry attached to
it (and pinned).

NAK.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/