Re: [PATCH 3/4] target: Drop se_lun->lun_active for existing percpu lun_ref

From: Hannes Reinecke
Date: Fri May 22 2015 - 03:59:07 EST


On 05/22/2015 09:06 AM, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
>
> With se_port_t and t10_alua_tg_pt_gp_member being absored into se_lun,
> there is no need for an extra atomic_t based reference count for PR
> ALL_TG_PT=1 and ALUA access state transition.
>
> Go ahead and use the existing percpu se_lun->lun_ref instead, and
> convert the two special cases to percpu_ref_tryget_live() to avoid
> se_lun if transport_clear_lun_ref() has already been invoked to
> shutdown the se_lun.
>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
> ---
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/