Re: [PATCH v4 11/13] staging: lnet: o2iblnd: checkpatch.pl fixes

From: Dan Carpenter
Date: Fri May 22 2015 - 06:50:06 EST


On Thu, May 21, 2015 at 03:50:34PM -0400, Mike Shuey wrote:
> @@ -2758,7 +2763,7 @@ void kiblnd_shutdown(lnet_ni_t *ni)
> i = 2;
> while (atomic_read(&net->ibn_npeers) != 0) {
> i++;
> - CDEBUG(((i & (-i)) == i) ? D_WARNING : D_NET, /* 2**n? */
> + CDEBUG(((i & (-i)) == i) ? D_WARNING : D_NET,/* 2**n? */

The original was better. I don't like this patch for the same reasons
that people complained about patch 10. It does too many things as well.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/