Re: [PATCH] Input: stmpe-ts - enforce device tree only mode

[Marek Vasut]

On Saturday, May 23, 2015 at 12:58:32 AM, Dmitry Torokhov wrote:
> The STMPE MFD is only used with device tree configured systems (and STMPE
> MFD core depends on OF), so force the configuration to come from device
> tree only.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---

Hi!

[...]

> @@ -351,14 +336,13 @@ static int stmpe_input_probe(struct platform_device
> *pdev) idev->name = STMPE_TS_NAME;
>  	idev->phys = STMPE_TS_NAME"/input0";
>  	idev->id.bustype = BUS_I2C;
> -	idev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
> -	idev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
> 
>  	idev->open = stmpe_ts_open;
>  	idev->close = stmpe_ts_close;
> 
>  	input_set_drvdata(idev, ts);
> 
> +	input_set_capability(idev, EV_KEY, BTN_TOUCH);

Isn't this part of the patch dropping the EV_ABS evbit ?

>  	input_set_abs_params(idev, ABS_X, 0, XY_MASK, 0, 0);
>  	input_set_abs_params(idev, ABS_Y, 0, XY_MASK, 0, 0);
>  	input_set_abs_params(idev, ABS_PRESSURE, 0x0, 0xff, 0, 0);


[...]

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/