Re: [PATCH] serial: 8250: remove return statements from void function

[Greg Kroah-Hartman]

On Mon, May 11, 2015 at 12:30:22PM +0900, Masahiro Yamada wrote:
> serial8250_set_mctrl() is a void type function.  Returning something
> does not look nice.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
> 
>  drivers/tty/serial/8250/8250_core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 4882027..146f56c 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -2019,8 +2019,9 @@ EXPORT_SYMBOL_GPL(serial8250_do_set_mctrl);
>  static void serial8250_set_mctrl(struct uart_port *port, unsigned int mctrl)
>  {
>  	if (port->set_mctrl)
> -		return port->set_mctrl(port, mctrl);
> -	return serial8250_do_set_mctrl(port, mctrl);
> +		port->set_mctrl(port, mctrl);
> +	else
> +		serial8250_do_set_mctrl(port, mctrl);
>  }

You just changed the logic here!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/