Re: [PATCH] atm:he - Do not initialise statics to 0.

[David Miller]

From: Shailendra Verma <shailendra.capricorn@xxxxxxxxx>
Date: Tue, 26 May 2015 01:23:53 +0530

> Static variables are initialised to 0 by GCC.
> Fixes the following checkpatch error:
> ERROR: do not initialise statics to 0 or NULL
> FILE: drivers/atm/he.c:120:
> static bool sdh = 0;
> 
> Signed-off-by: Shailendra Verma <shailendra.capricorn@xxxxxxxxx>

true is not necessarily '1' and false is not necessarily '0',
therefore the correct fix would be to assign 'false' to this variable.

Furthermore you've submitted this in such a way that it cannot be
applied alongside the other atm:he patch you submitted.

This is why when you submit multiple patches to the same file, you
must group them and submit them relative to eachother and in a
specific order.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/