Re: [RFC PATCH] video/logo: introduce new system state for checking if logos are freed

[Heiko Schocher]

Hello Geert,

Am 26.05.2015 09:25, schrieb Geert Uytterhoeven:
> On Tue, May 26, 2015 at 9:17 AM, Heiko Schocher <hs@xxxxxxx> wrote:
> > 4) draw only one logo even on multicores ... why must every core draw
> > a logo? Currently each core draws the logo, and on a system with more
> > than 4 cores, I think this looks not really good ...
>
> I don't think each core draws a logo. They're all drawn from fbcon_switch().

Hmm... I have here an imx6dl based system, and it draws two logos when booting...
I can prevent this two logos, if I do:

diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index 0705d88..e907ab9 100644
--- a/drivers/video/fbdev/core/fbmem.c
+++ b/drivers/video/fbdev/core/fbmem.c
@@ -664,8 +672,7 @@ int fb_show_logo(struct fb_info *info, int rotate)
 {
        int y;

-       y = fb_show_logo_line(info, rotate, fb_logo.logo, 0,
-                             num_online_cpus());
+       y = fb_show_logo_line(info, rotate, fb_logo.logo, 0, 1);
        y = fb_show_extra_logos(info, y, rotate);

        return y;

> > Hmm... I do not really have a lot experience in this area ... but why
> > is the logo only drawed when booting? Is there nothing like a "redraw"
> > of it?
>
> When do you want to redraw it? On VC switch (it's drawn on the first call
> only, hence it disappears if you switch VC and back)?
> Until when should it be redrawn?

I don;t know, it was just a question ... If this is not possible, we
do not need to cover such a case, good!

bye,
Heiko
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/