RE: [PATCH v3 1/2] ALSA: Kconfig: add config item SND_PROC_FS for expert

From: Jie, Yang
Date: Wed May 27 2015 - 07:12:51 EST


> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@xxxxxxx]
> Sent: Wednesday, May 27, 2015 5:56 PM
> To: Jie, Yang
> Cc: broonie@xxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Girdwood, Liam R; Zhang, Vivian
> Subject: Re: [PATCH v3 1/2] ALSA: Kconfig: add config item SND_PROC_FS for
> expert
>
> At Wed, 27 May 2015 17:10:17 +0800,
> Jie Yang wrote:
> >
> > For some embedded devices, we need reduce code size and data footprint
> > as much as possible, e.g. disabling procfs, hw/sw params refinement,
> > mmap, dpcm, dapm, compressed API...
> >
> > Here add SND_PROC_FS item for expert, we can unselect it to disable
> > sound proc FS and reduce memory footprint.
> >
> > Signed-off-by: Jie Yang <yang.jie@xxxxxxxxx>
> > ---
> > sound/core/Kconfig | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/sound/core/Kconfig b/sound/core/Kconfig index
> > 63cc2e9..4542554 100644
> > --- a/sound/core/Kconfig
> > +++ b/sound/core/Kconfig
> > @@ -225,4 +225,13 @@ config SND_DMA_SGBUF
> > def_bool y
> > depends on X86
> >
> > +config SND_PROC_FS
> > + bool "Sound Proc FS Support" if EXPERT
> > + depends on PROC_FS
> > + default y
> > + help
> > + Say 'N' to disable Sound proc FS, which may reduce code size about
> > + 9KB on x86_64 platform.
> > + If unsure say Y.
> > +
> > source "sound/core/seq/Kconfig"
>
> There is SND_VERBOSE_PROCFS that also depends on PROC_FS.
> You should change it as well to depend on SND_PROC_FS.

OK, will change it also.

~Keyon

>
>
> Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/