Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

From: Borislav Petkov
Date: Wed May 27 2015 - 08:51:52 EST


On Wed, May 27, 2015 at 06:12:59PM +0600, Alexander Kuleshov wrote:
> Is it bad or we no need in it? I want to understand not only how
> kernel works, but also why it written so and I can't understand why we
> have 'earlyprintk' (or another feature) in one place and do not have
> in another.

So how hard was it to say that the first time?

That you want to be able to dump interesting parts of the early boot
process and you would like the early console working as early as
possible?

This is what I wanted to know - what is your use case. Not what is there
and what isn't there in the code. That I can figure out by browsing the
code myself. Most of the time, at least. :-)

Now, have you tested this on real hardware? Because your 0/n message
said "qemu" but I don't think that's sufficient. If we're going to
enable early_printk this early, we'd need it working on real hardware
too.

For that I'd suggest adding a 4th, test patch which issues a couple of
numbered early_printk() lines which we could run on a bunch of machines
to see whether it actually works.

Thanks.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/