Re: [PATCH 2/2] USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver()

From: Greg KH
Date: Wed May 27 2015 - 11:00:19 EST


On Wed, May 27, 2015 at 07:19:15PM +0530, Abhishek Bist wrote:
> This function is used to call before 2.6.x version of linux kernel but since then I haven't seen it's relative usage and it's not
> being used any where right now after checking it through linux.crossrefrence.So, IMHO it would be relevant to remove this obselete
> function from kernel mainline.

Please properly wrap your changelog lines at 72 columns.

> Signed-off-by: Abhishek Bist <ishubist@xxxxxxxxx>
> ---
> include/linux/usb/hcd.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index 68b1e83..c9aa779 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -622,8 +622,6 @@ extern struct list_head usb_bus_list;
> extern struct mutex usb_bus_list_lock;
> extern wait_queue_head_t usb_kill_urb_queue;
>
> -extern int usb_find_interface_driver(struct usb_device *dev,
> - struct usb_interface *interface);

Good catch, care to fix up the wording in your changelog and resend
this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/