RE: Build errors in -next due to 'drivers:usb:fsl:Make fsl ehci drv an independent driver module'

From: Ramneek Mehresh
Date: Wed May 27 2015 - 23:55:40 EST




> -----Original Message-----
> From: Guenter Roeck [mailto:linux@xxxxxxxxxxxx]
> Sent: Thursday, May 28, 2015 1:29 AM
> To: Mehresh Ramneek-B31383
> Cc: Alan Stern; Greg Kroah-Hartman; linux-kernel@xxxxxxxxxxxxxxx; linux-
> next@xxxxxxxxxxxxxxx
> Subject: Build errors in -next due to 'drivers:usb:fsl:Make fsl ehci drv an
> independent driver module'
>
> Hi,
>
> your patch 'drivers:usb:fsl:Make fsl ehci drv an independent driver module'
> converts the driver into a separate module. Unfortunately, it uses non-
> exported functions from the ehci core code. This results in compile errors for
> several powerpc configurations.
>
> drivers/usb/host/ehci-fsl.c: In function 'ehci_fsl_drv_suspend':
> drivers/usb/host/ehci-fsl.c:531:2: error: implicit declaration of function
> 'ehci_adjust_port_wakeup_flags'
> drivers/usb/host/ehci-fsl.c: In function 'ehci_fsl_drv_resume':
> drivers/usb/host/ehci-fsl.c:561:2: error: implicit declaration of function
> 'ehci_reset'
>
Understood...apologies for the inconvenience caused. This problem comes when both
ehci_hcd and ehci_fsl are built as modules. Till now, only ehci-hcd was build as
module, and other drivers were built into it. I tested ehci_fsl as a module with ehci_hcd as build-in.

Now, there are two solutions for this.
1. export each function in ehci_hcd.c
2. I make ehci-fsl.c as built-in

Please suggest.

> Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/