Re: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.

[Jan Kardell]

Alexandre Belloni skrev:
> Hi,
>
> On 27/05/2015 at 14:48:16 +0200, Jan Kardell wrote :
> > @@ -204,6 +204,7 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm)
> >   		pcf8563->voltage_low = 1;
> >   		dev_info(&client->dev,
> Aren't dev_err or dev_warn more appropriate? You used dev_err in your
> first patch, what made you change your mind?
Your comment to the first patch. But I interpreted it to broadly.
I'll change it back to dev_err.
> >   			"low voltage detected, date/time is not reliable.\n");
> > +		return -EINVAL;
> >   	}
> >   
> >   	dev_dbg(&client->dev,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/