Re: [PATCH v5 00/10] latched RB-trees and __module_address()

From: Peter Zijlstra
Date: Thu May 28 2015 - 07:20:19 EST


On Thu, May 28, 2015 at 11:37:17AM +0930, Rusty Russell wrote:
> That's rcu_read_lock_sched_held, not rcu_held_lock_sched_held().
>
> Also, your unlikely is weird and backwards.
>
> I changed it as below, and folded. It's in modules-next.
>
> I'm now going to do some *actual* testing, and I'll go all Torvalds on
> you if this spews warnings...

Fair enough, I did see the build robot fail on this. How come those only
showed up now? This patch has been in your git tree for a long time; you
picked up the rcu validation patches before the other ones.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/