Re: [PATCH 2/3 v4] ARM: bcm2835: Add the Raspberry Pi firmware driver

[Noralf Trønnes]

Den 29.05.2015 00:38, skrev Eric Anholt:
> Noralf Trønnes <noralf@xxxxxxxxxxx> writes:
>
> > Den 28.05.2015 20:33, skrev Eric Anholt:
> > > This gives us a function for making mailbox property channel requests
> > > of the firmware, which is most notable in that it will let us get and
> > > set clock rates.
> > >
> > > Signed-off-by: Eric Anholt <eric@xxxxxxxxxx>
> > ...
> > > +static int rpi_firmware_probe(struct platform_device *pdev)
> > > +{
> > > +	struct device *dev = &pdev->dev;
> > > +	struct rpi_firmware *fw;
> > > +
> > > +	fw = devm_kzalloc(dev, sizeof(*fw), GFP_KERNEL);
> > > +	if (!fw)
> > > +		return -ENOMEM;
> > > +
> > > +	fw->cl.dev = dev;
> > > +	fw->cl.rx_callback = response_callback;
> > > +	fw->cl.tx_block = true;
> > > +
> > > +	fw->chan = mbox_request_channel(&fw->cl, 0);
> > > +	if (IS_ERR(fw->chan)) {
> > > +		int ret = PTR_ERR(fw->chan);
> > > +		if (ret != -EPROBE_DEFER)
> > > +			dev_err(dev, "Failed to get mbox channel: %d\n", ret);
> > > +		return ret;
> > > +	}
> > > +
> > > +	init_completion(&fw->c);
> > > +
> > > +	platform_set_drvdata(pdev, fw);
> > > +
> > > +	rpi_firmware_print_firmware_revision(dev);
> > > +
> > > +	return 0;
> > > +}
> > > +
> > > +static int rpi_firmware_remove(struct platform_device *pdev)
> > > +{
> > > +	struct rpi_firmware *fw = platform_get_drvdata(pdev);
> > > +
> > > +	mbox_free_channel(fw->chan);
> > I guess driver data has to be reset here:
> > platform_set_drvdata(pdev, NULL);
> Fixed.

I was wrong about this one as Stephen pointed out.
My point became mute now that rpi_firmware_property_list() doesn't look 
up driver data anymore.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/