Re: [PATCH] x86/xen: use schedule_timeout_interruptible()

From: Boris Ostrovsky
Date: Fri May 29 2015 - 10:45:13 EST


On 05/29/2015 09:49 AM, Nicholas Mc Guire wrote:
API consolidation with coccinelle found:
./arch/x86/xen/smp.c:499:2-18:
consolidation with schedule_timeout_*() recommended

This is a 1:1 conversion of the current calls to an available helper
only - so only an API consolidation to improve readability.

Patch was compile tested with x86_64_defconfig +
CONFIG_HYPERVISOR_GUEST=y,CONFIG_PARAVIRT=y,CONFIG_XEN=y:

Patch is against 4.1-rc5 (localversion-next is -next-20150529)

Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>

Reviewed-by: Boris Ostrovsky < boris.ostrovsky@xxxxxxxxxx>

---
arch/x86/xen/smp.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
index 8648438..6cbbfc8 100644
--- a/arch/x86/xen/smp.c
+++ b/arch/x86/xen/smp.c
@@ -494,10 +494,8 @@ static int xen_cpu_disable(void)
static void xen_cpu_die(unsigned int cpu)
{
- while (xen_pv_domain() && HYPERVISOR_vcpu_op(VCPUOP_is_up, cpu, NULL)) {
- __set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ/10);
- }
+ while (xen_pv_domain() && HYPERVISOR_vcpu_op(VCPUOP_is_up, cpu, NULL))
+ schedule_timeout_uninterruptible(msecs_to_jiffies(100));
if (common_cpu_die(cpu) == 0) {
xen_smp_intr_free(cpu);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/