Re: [PATCH v3 5/6] Watchdog: introduce ARM SBSA watchdog driver

[Guenter Roeck]

On 05/29/2015 08:46 AM, Timur Tabi wrote:
> On 05/29/2015 09:32 AM, Fu Wei wrote:
> > It is a SPI, every CPU can get it,
> > But maybe I miss something, but please let me know if other CPU can
> > not get the interrupt.
>
> There's only one watchdog device, so there's only one interrupt.  I don't know which CPU will get the interrupt, but the watchdog is not a per-CPU device.
Plus, that one interrupt is not shared, and the driver returns
IRQ_HANDLED even if the bit is not set. So _something_ is definitely
wrong. Either the interrupt is shared, then it needs to be requested
as shared and the handler should only return IRQ_HANDLED if it actually
handles the interrupt. Or it is not shared and the handler should always
handle it.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/