Re: [PATCH v2] security_syslog() should be called once only

[Vasily Averin]

On 28.05.2015 02:43, Andrew Morton wrote:
> So we run security_syslog() for actions other than open() (of kmsg). 
> Why?
Could you please clarify this question?

Linux kernel have reasonable default security policy and it's great.
And at the same time kernel allows to override default behaviour
and set custom security policy.
For example, to prohibit work on Saturday.
QA can use it for random failures generation.
Why not?

> Also, that from_file handling makes me cry.
...
> One possible fix would be something like this, plus various
> fixups/audit:

I've prepared such patch and send it in separate letter.

> And `type' should be renamed to `action' for heavens sake.

IMHO 'type' and SYSLOG_ACTION_* was inherited from sys_syslog definition.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/