Re: [PATCH v3 1/4] sched/rt: Check to push the task away after its affinity was changed

From: Steven Rostedt
Date: Sat May 30 2015 - 12:31:05 EST


On Sat, 30 May 2015 12:54:23 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Sat, 2015-05-30 at 10:20 +0200, Peter Zijlstra wrote:
> > Makes me like the thing even less though..
>
> Steven, why do we normally push on schedule()? Would not the natural
> location be where we add to pushable_tasks?
>
> Which would be here in set_cpus_allowed() and wakeups. schedule() seems
> like a second best location.

What about when an RT task gets preempted by a higher prio task. We may
need to push the preempted one. You can't do that at wakeup.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/