Re: [PATCH 1/1] net: core: 'ethtool' issue with querying phy settings

From: David Miller
Date: Mon Jun 01 2015 - 17:46:48 EST


From: Arun Parameswaran <aparames@xxxxxxxxxxxx>
Date: Mon, 1 Jun 2015 14:41:43 -0700

> It would be nice for the 'ethtool' to be flexible to support querying
> specific PHY irrespective of the net implementation, but that is being
> discussed in the other thread.

Please stop arguing about this, it isn't valid.

Your device is a switch, and therefore needs to be represented properly
with the proper number of net_device objects.

Even more importantly, the ethtool API is established and you cannot
change these semantics without potentially breaking lots of applications
and libraries out there.

Your change is reverted, and I will absolutely not entertain any
attempt to again change the semantics of this ethtool operation.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/