Re: [PATCH] watchdog: mena21_wdt: Fix possible NULL pointer dereference

[Guenter Roeck]

On 06/02/2015 03:25 AM, Johannes Thumshirn wrote:
> In a21_wdt_remove() we do a watchdog_unregister_device() on struct
> a21_wdt_drv->wdt but never assign it.
>
> Also move the dev_set_drvdata() call in front of the watchdog_register_device()
> call, so it doesn't look like an error.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

Good catch.

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/