Re: [PATCH 1/2] null_blk: prevent timer handler running on a different CPU where started

From: Jens Axboe
Date: Tue Jun 02 2015 - 10:44:47 EST


On 06/01/2015 05:35 PM, Akinobu Mita wrote:
When irqmode=2 (IRQ completion handler is timer), timer handler should
be called on the same CPU where the timer has been started.

Since completion_queues are per-cpu and the completion handler only
touches completion_queue for local CPU, we need to prevent the handler
from running on a different CPU where the timer has been started.
Otherwise, the IO cannot be completed until another completion handler
is executed on that CPU.

Thanks, applied this and 2/2, the latter seems to have been forgotten after our initial discussion about it.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/