Re: [PATCH 1/2] x86/asm/entry/32: Open-code CLEAR_RREGS. No code changes.

From: Steven Rostedt
Date: Tue Jun 02 2015 - 15:35:11 EST


On Tue, 2 Jun 2015 21:04:01 +0200
Denys Vlasenko <dvlasenk@xxxxxxxxxx> wrote:

> This macro is small, has only four callsites, and one of them is
> slightly different using a conditional parameter.
>
> A few saved lines aren't worth the resulting obfuscation.

I'm curious, why? Did someone recommend this change? I don't see it as
obfuscation at all.

-- Steve


>
> Generated machine code is identical.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/