Re: [RFC][PATCH 7/7] sched,dl: Convert switched_{from,to}_dl() / prio_changed_dl() to balance callbacks

From: Kamalesh Babulal
Date: Wed Jun 03 2015 - 00:53:11 EST


* Peter Zijlstra <peterz@xxxxxxxxxxxxx> [2015-06-01 15:58:25]:

[...]

>
> -static DEFINE_PER_CPU(struct callback_head, dl_balance_head);
> +static DEFINE_PER_CPU(struct callback_head, dl_push_head);
> +static DEFINE_PER_CPU(struct callback_head, dl_pull_head);
>
> static void push_dl_tasks(struct rq *);
> +static void pull_dl_task(struct rq *);
>
> static inline void queue_push_tasks(struct rq *rq)
> {
> if (!has_pushable_dl_tasks(rq))
> return;
>
> - queue_balance_callback(rq, &per_cpu(dl_balance_head, rq->cpu), push_dl_tasks);
> + queue_balance_callback(rq, &per_cpu(dl_push_head, rq->cpu), push_dl_tasks);
> +}
> +
> +static inline void queue_pull_task(struct rq *rq)
> +{
> + queue_balance_callback(rq, &per_cpu(dl_pull_head, rq->cpu), pull_dl_task);
> }

queue_pull_task() is not defined for CONFIG_SMP=n case, following build error
is seen while building the kernel with SMP=n:

CC kernel/sched/deadline.o
kernel/sched/deadline.c: In function â??switched_from_dlâ??:
kernel/sched/deadline.c:1713:2: error: implicit declaration of function â??queue_pull_taskâ?? [-Werror=implicit-function-declaration]
queue_pull_task(rq);
^
cc1: some warnings being treated as errors

Thanks,
Kamalesh.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/