Re: [sched/preempt] BUG: kernel boot crashed

From: Peter Zijlstra
Date: Thu Jun 04 2015 - 05:41:03 EST


On Thu, Jun 04, 2015 at 12:55:36PM +0800, Fengguang Wu wrote:
> Greetings,
>
> 0day kernel testing robot got the below dmesg and the first bad commit is
>
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>
> commit b30f0e3ffedfa52b1d67a302ae5860c49998e5e2
> Author: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> AuthorDate: Tue May 12 16:41:49 2015 +0200
> Commit: Ingo Molnar <mingo@xxxxxxxxxx>
> CommitDate: Tue May 19 08:39:12 2015 +0200
>
> sched/preempt: Optimize preemption operations on __schedule() callers
>
> __schedule() disables preemption and some of its callers
> (the preempt_schedule*() family) also set PREEMPT_ACTIVE.
>
> So we have two preempt_count() modifications that could be performed
> at once.
>
> Lets remove the preemption disablement from __schedule() and pull
> this responsibility to its callers in order to optimize preempt_count()
> operations in a single place.
>
> Suggested-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Link: http://lkml.kernel.org/r/1431441711-29753-5-git-send-email-fweisbec@xxxxxxxxx
> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>

Frederic said that he was working on the issue and we should expect
patches shortly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/