Re: [RFC PATCH 02/12] mm: introduce mirror_info

From: Xishi Qiu
Date: Thu Jun 04 2015 - 21:57:12 EST


On 2015/6/5 0:57, Luck, Tony wrote:

> +#ifdef CONFIG_MEMORY_MIRROR
> +struct numa_mirror_info {
> + int node;
> + unsigned long start;
> + unsigned long size;
> +};
> +
> +struct mirror_info {
> + int count;
> + struct numa_mirror_info info[MAX_NUMNODES];
> +};
>
> Do we really need this? My patch series leaves all the mirrored memory in
> the memblock allocator tagged with the MEMBLOCK_MIRROR flag. Can't
> we use that information when freeing the boot memory into the runtime
> free lists?
>

Hi Tony,

I used this code for testing before, so when your patchset added to mainline,
I'll rewrite it, use MEMBLOCK_MIRROR, not mirror_info.

I find Andrew has added your patches to mm-tree, right?

Thanks,
Xishi Qiu

> If we can't ... then [MAX_NUMNODES] may not be enough. We may have
> more than one mirrored range on each node. Current h/w allows two ranges
> per node.
>
> -Tony
>
> .
>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/