Re: [PATCH] extcon: max77843: Clear IRQ bits state before request IRQ

From: Chanwoo Choi
Date: Fri Jun 05 2015 - 00:54:05 EST


Hi Jaewon,

On 06/05/2015 01:32 PM, Jaewon Kim wrote:
> IRQ signal before driver probe is needless because driver sends
> current state after platform booting done.
> So, this patch clears MUIC IRQ bits before request IRQ.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@xxxxxxxxxxx>
> ---
> drivers/extcon/extcon-max77843.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
> index d78a64d..11e09d1 100644
> --- a/drivers/extcon/extcon-max77843.c
> +++ b/drivers/extcon/extcon-max77843.c
> @@ -781,6 +781,15 @@ static int max77843_muic_probe(struct platform_device *pdev)
> /* Support virtual irq domain for max77843 MUIC device */
> INIT_WORK(&info->irq_work, max77843_muic_irq_work);
>
> + /* Clear IRQ bits before request IRQs */
> + ret = regmap_bulk_read(max77843->regmap_muic,
> + MAX77843_MUIC_REG_INT1, info->status,
> + MAX77843_MUIC_IRQ_NUM);
> + if (ret) {
> + dev_err(&pdev->dev, "Failed to Clear IRQ bits\n");
> + goto err_muic_irq;
> + }
> +
> for (i = 0; i < ARRAY_SIZE(max77843_muic_irqs); i++) {
> struct max77843_muic_irq *muic_irq = &max77843_muic_irqs[i];
> unsigned int virq = 0;
>

Applied it.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/