Re: [PATCH v2 1/2] devicetree:bindings: add devicetree bindings for ceva ahci

From: Michal Simek
Date: Fri Jun 05 2015 - 02:46:43 EST


On 06/05/2015 08:02 AM, Suneel Garapati wrote:
> adds bindings for CEVA AHCI SATA controller. optional property
> broken-gen2 is useful incase of hardware speed limitation.
>
> Signed-off-by: Suneel Garapati <suneel.garapati@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/ata/ahci-ceva.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ata/ahci-ceva.txt
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-ceva.txt b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> new file mode 100644
> index 0000000..7ca8b97
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> @@ -0,0 +1,20 @@
> +Binding for CEVA AHCI SATA Controller
> +
> +Required properties:
> + - reg: Physical base address and size of the controller's register area.
> + - compatible: Compatibility string. Must be 'ceva,ahci-1v84'.
> + - clocks: Input clock specifier. Refer to common clock bindings.
> + - interrupts: Interrupt specifier. Refer to interrupt binding.
> +
> +Optional properties:
> + - ceva,broken-gen2: limit to gen1 speed instead of gen2.
> +
> +Examples:
> + ahci@fd0c0000 {
> + compatible = "ceva,ahci-1v84";
> + reg = <0xfd0c0000 0x200>;
> + interrupt-parent = <&gic>;
> + interrupts = <0 133 4>;
> + clocks = <&clkc SATA_CLK_ID>;
> + ceva,broken-gen2;
> + };
> --
> 2.1.2

Acked-by: Michal Simek <michal.simek@xxxxxxxxxx>

FYI: Adding ceva prefix to vendor-prefixes is already in arm-soc tree.
And
ceva,broken-gen2 targets hardware limitation.

Thanks,
Michal


--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


Attachment: signature.asc
Description: OpenPGP digital signature